[
https://issues.apache.org/jira/browse/PARQUET-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226711#comment-16226711
]
Nandor Kollar commented on PARQUET-1152:
----------------------------------------
I'd propose these options:
* Remove this problematic code: {code}
if (IS_READ_LENGTH_SETABLE && protocol instanceof TBinaryProtocol) {
((TBinaryProtocol)protocol).setReadLength(record.getLength());
}
{code}
* use reflection to call {{setReadLength}}, like Ryan mentioned in PARQUET-180
(instead of a boolean, store the Method itself), this might have some -
hopefully minor - performance regression.
* introduce a new profile for Thrift 0.9.3+, and compile different Java classes
based on this profile, one class with the aforementioned code for 0.9.3- and
one for 0.9.3+.
I also tried to compile with latest Thrift (0.10.0), that failed too, due to
THRIFT-2263. The default generator parameter used for {{--gen}} argument by
Thrift Maven plugin is no longer supported, this can be fixed with an
additional {{<generator>java</generator>}} parameter to Thrift Maven plugin
> Parquet-thrift doesn't compile with Thrift 0.9.3
> ------------------------------------------------
>
> Key: PARQUET-1152
> URL: https://issues.apache.org/jira/browse/PARQUET-1152
> Project: Parquet
> Issue Type: Bug
> Reporter: Nandor Kollar
> Assignee: Nandor Kollar
>
> Parquet-thrift doesn't compile with Thrift 0.9.3, because
> TBinaryProtocol#setReadLength method was removed.
> PARQUET-180 already addressed the problem, but only in runtime.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
