Hi,

The last three pull requests I reviewed included removal of trailing spaces
in unrelated lines of the affected files. I was wondering whether we are
fine with such changes.

These trailing spaces should not have been committed in the first place,
but removing them later adds unnecessary clutter to the file history and
can cause problems when cherry-picking/merging/rebasing/blaming. One more
thing to take into consideration is that when someone has a change with
both code changes and unrelated whitespace changes, removing the latter is
only possible via tedious manual work (as far as I know), so I am somewhat
reluctant to request that.

What is the preferred approach here?

Thanks,

Zoltan

Reply via email to