[
https://issues.apache.org/jira/browse/PARQUET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337913#comment-16337913
]
ASF GitHub Bot commented on PARQUET-41:
---------------------------------------
daedric commented on a change in pull request #432: PARQUET-41: Add bloom
filter for parquet
URL: https://github.com/apache/parquet-cpp/pull/432#discussion_r163618131
##########
File path: src/parquet/bloom.cc
##########
@@ -0,0 +1,215 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#include "parquet/bloom.h"
+
+#include <algorithm>
+#include <cstdint>
+
+#include "arrow/util/bit-util.h"
+
+#include "parquet/exception.h"
+#include "parquet/murmur3.h"
+#include "parquet/util/logging.h"
+
+namespace parquet {
+constexpr uint32_t Bloom::SALT[8];
+
+Bloom::Bloom(uint32_t num_bytes)
+ : num_bytes(num_bytes),
+ hash_strategy(MURMUR3_X64_128),
+ algorithm(BLOCK),
+ hashFunc(NULL) {
+ initBitset(num_bytes);
+
+ switch (hash_strategy) {
+ case MURMUR3_X64_128:
+ this->hashFunc = &MurmurHash3_x64_128;
+ break;
+ default:
+ throw parquet::ParquetException("Unknown hash strategy.");
+ }
+}
+
+void Bloom::initBitset(uint32_t num_bytes) {
+ if (num_bytes < BYTES_PER_FILTER_BLOCK) {
+ num_bytes = BYTES_PER_FILTER_BLOCK;
+ }
+
+ if (num_bytes > DEFAULT_MAXIMUM_BLOOM_FILTER_BYTES) {
+ num_bytes = DEFAULT_MAXIMUM_BLOOM_FILTER_BYTES;
+ }
+
+ // Get next power of 2 if it is not power of 2.
+ if ((num_bytes & (num_bytes - 1)) != 0) {
+ num_bytes = static_cast<uint32_t>(::arrow::BitUtil::NextPower2(num_bytes));
+ }
+
+ this->bitset = new uint8_t[num_bytes];
+}
+
+Bloom::Bloom(const uint8_t* bitset, uint32_t num_bytes)
+ : num_bytes(num_bytes),
+ hash_strategy(MURMUR3_X64_128),
+ algorithm(BLOCK){
+ this->bitset = new uint8_t[num_bytes];
+ memcpy(this->bitset, bitset, num_bytes);
+ switch (hash_strategy) {
+ case MURMUR3_X64_128:
+ this->hashFunc = &MurmurHash3_x64_128;
+ break;
+ default:
+ throw new parquet::ParquetException("Not supported hash strategy");
Review comment:
are you sure you want to new the exception ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add bloom filters to parquet statistics
> ---------------------------------------
>
> Key: PARQUET-41
> URL: https://issues.apache.org/jira/browse/PARQUET-41
> Project: Parquet
> Issue Type: New Feature
> Components: parquet-format, parquet-mr
> Reporter: Alex Levenson
> Assignee: Ferdinand Xu
> Priority: Major
> Labels: filter2
>
> For row groups with no dictionary, we could still produce a bloom filter.
> This could be very useful in filtering entire row groups.
> Pull request:
> https://github.com/apache/parquet-mr/pull/215
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
