[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342586#comment-16342586
]
ASF GitHub Bot commented on PARQUET-1179:
-----------------------------------------
xhochy closed pull request #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/before_script_travis.sh b/ci/before_script_travis.sh
index 4251ee5f..95a2fd82 100755
--- a/ci/before_script_travis.sh
+++ b/ci/before_script_travis.sh
@@ -16,8 +16,10 @@ if [ $TRAVIS_OS_NAME == "osx" ]; then
brew update > /dev/null
brew install boost
brew install openssl
+ brew install bison
export OPENSSL_ROOT_DIR=/usr/local/opt/openssl
export LD_LIBRARY_PATH=/usr/local/opt/openssl/lib:$LD_LIBRARY_PATH
+ export PATH="/usr/local/opt/bison/bin:$PATH"
else
# Use a C++11 compiler on Linux
export CC="gcc-4.9"
diff --git a/ci/msvc-build.bat b/ci/msvc-build.bat
index 29d8b839..46d4aeac 100644
--- a/ci/msvc-build.bat
+++ b/ci/msvc-build.bat
@@ -28,7 +28,7 @@ if NOT "%CONFIGURATION%" == "Debug" (
)
if "%CONFIGURATION%" == "Toolchain" (
- conda install -y boost-cpp=1.63 thrift-cpp=0.10.0 ^
+ conda install -y boost-cpp=1.63 thrift-cpp=0.11.0 ^
brotli=0.6.0 zlib=1.2.11 snappy=1.1.6 lz4-c=1.7.5 zstd=1.2.0 ^
-c conda-forge
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 52ab7a8d..2ea76860 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -17,7 +17,7 @@
set(GTEST_VERSION "1.8.0")
set(GBENCHMARK_VERSION "1.1.0")
-set(THRIFT_VERSION "0.10.0")
+set(THRIFT_VERSION "0.11.0")
string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
diff --git a/src/parquet/thrift.h b/src/parquet/thrift.h
index 7a23e417..d2915a94 100644
--- a/src/parquet/thrift.h
+++ b/src/parquet/thrift.h
@@ -19,9 +19,7 @@
#define PARQUET_THRIFT_UTIL_H
#include <cstdint>
-
-// Needed for thrift
-#include <boost/shared_ptr.hpp>
+#include <memory>
// TCompactProtocol requires some #defines to work right.
#define SIGNED_RIGHT_SHIFT_IS 1
@@ -96,12 +94,12 @@ static inline format::CompressionCodec::type
ToThrift(Compression::type type) {
template <class T>
inline void DeserializeThriftMsg(const uint8_t* buf, uint32_t* len, T*
deserialized_msg) {
// Deserialize msg bytes into c++ thrift msg using memory transport.
- boost::shared_ptr<apache::thrift::transport::TMemoryBuffer> tmem_transport(
+ std::shared_ptr<apache::thrift::transport::TMemoryBuffer> tmem_transport(
new apache::thrift::transport::TMemoryBuffer(const_cast<uint8_t*>(buf),
*len));
apache::thrift::protocol::TCompactProtocolFactoryT<
apache::thrift::transport::TMemoryBuffer>
tproto_factory;
- boost::shared_ptr<apache::thrift::protocol::TProtocol> tproto =
+ std::shared_ptr<apache::thrift::protocol::TProtocol> tproto =
tproto_factory.getProtocol(tmem_transport);
try {
deserialized_msg->read(tproto.get());
@@ -119,12 +117,12 @@ inline void DeserializeThriftMsg(const uint8_t* buf,
uint32_t* len, T* deseriali
// the expected size of the serialized object
template <class T>
inline int64_t SerializeThriftMsg(T* obj, uint32_t len, OutputStream* out) {
- boost::shared_ptr<apache::thrift::transport::TMemoryBuffer> mem_buffer(
+ std::shared_ptr<apache::thrift::transport::TMemoryBuffer> mem_buffer(
new apache::thrift::transport::TMemoryBuffer(len));
apache::thrift::protocol::TCompactProtocolFactoryT<
apache::thrift::transport::TMemoryBuffer>
tproto_factory;
- boost::shared_ptr<apache::thrift::protocol::TProtocol> tproto =
+ std::shared_ptr<apache::thrift::protocol::TProtocol> tproto =
tproto_factory.getProtocol(mem_buffer);
try {
mem_buffer->resetBuffer();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Support Apache Thrift 0.11
> --------------------------------
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
> Reporter: Stephen Carman
> Assignee: Wes McKinney
> Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(tmem_transport);
> ^~~~~~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(mem_buffer);
> ^~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> 2 errors generated.
> make[2]: *** [CMakeFiles/parquet_objlib.dir/src/parquet/schema.cc.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/writer-internal.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(tmem_transport);
> ^~~~~~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/writer-internal.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(mem_buffer);
> ^~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> 2 errors generated.
> make[2]: ***
> [CMakeFiles/parquet_objlib.dir/src/parquet/file/writer-internal.cc.o] Error 1
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/reader-internal.cc:32:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(tmem_transport);
> ^~~~~~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/reader-internal.cc:32:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(mem_buffer);
> ^~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> 2 errors generated.
> make[2]: ***
> [CMakeFiles/parquet_objlib.dir/src/parquet/file/reader-internal.cc.o] Error 1
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/metadata.cc:26:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(tmem_transport);
> ^~~~~~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/file/metadata.cc:26:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'stdcxx::shared_ptr<TTransport>'
> tproto_factory.getProtocol(mem_buffer);
> ^~~~~~~~~~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to 'const
> std::__1::shared_ptr<apache::thrift::transport::TTransport> &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr<apache::thrift::transport::TMemoryBuffer>' to
> 'std::__1::shared_ptr<apache::thrift::transport::TTransport> &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template<class _Yp> _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr<TProtocol> getProtocol(stdcxx::shared_ptr<TTransport>
> trans) {
> ^
> 2 errors generated.
> make[2]: *** [CMakeFiles/parquet_objlib.dir/src/parquet/file/metadata.cc.o]
> Error 1
> make[1]: *** [CMakeFiles/parquet_objlib.dir/all] Error 2
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
