[ 
https://issues.apache.org/jira/browse/PARQUET-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362456#comment-16362456
 ] 

ASF GitHub Bot commented on PARQUET-1210:
-----------------------------------------

xhochy closed pull request #437: PARQUET-1210: [C++] Completely disable boost 
autolink on MSVC build
URL: https://github.com/apache/parquet-cpp/pull/437
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cmake_modules/ThirdpartyToolchain.cmake 
b/cmake_modules/ThirdpartyToolchain.cmake
index b749ab63..08b2a4cf 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -61,14 +61,15 @@ set(Boost_USE_MULTITHREADED ON)
 if (MSVC AND PARQUET_USE_STATIC_CRT)
   set(Boost_USE_STATIC_RUNTIME ON)
 endif()
+if (MSVC)
+  # disable autolinking in boost
+  add_definitions(-DBOOST_ALL_NO_LIB)
+endif()
 if (PARQUET_BOOST_USE_SHARED)
   # Find shared Boost libraries.
   set(Boost_USE_STATIC_LIBS OFF)
 
   if (MSVC)
-    # disable autolinking in boost
-    add_definitions(-DBOOST_ALL_NO_LIB)
-
     # force all boost libraries to dynamic link
     add_definitions(-DBOOST_ALL_DYN_LINK)
     find_package(Boost COMPONENTS regex system REQUIRED)


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Boost 1.66 compilation fails on Windows on linkage stage
> --------------------------------------------------------------
>
>                 Key: PARQUET-1210
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1210
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>         Environment: Windows
>            Reporter: Max Risuhin
>            Assignee: Max Risuhin
>            Priority: Major
>             Fix For: cpp-1.4.0
>
>
> Boost's autolinking should be disable on compilation with MSVC, since it 
> causes linkage with shared import libs, instead of expected static. Following 
> error occurs:
> `LINK : fatal error LNK1104: cannot open file 'boost_filesystem.lib'`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to