[
https://issues.apache.org/jira/browse/PARQUET-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368686#comment-16368686
]
ASF GitHub Bot commented on PARQUET-1218:
-----------------------------------------
renato2099 commented on a change in pull request #438: PARQUET-1218: More
informative error message on too short pages
URL: https://github.com/apache/parquet-cpp/pull/438#discussion_r168967444
##########
File path: src/parquet/column_reader.cc
##########
@@ -182,7 +182,10 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
// Read the compressed data page.
buffer = stream_->Read(compressed_len, &bytes_read);
if (bytes_read != compressed_len) {
- ParquetException::EofException();
+ std::stringstream ss;
+ ss << "Page was smaller (" << bytes_read << ") than expected (" <<
compressed_len
+ << ")";
+ ParquetException::EofException("Page was smaller than expected");
Review comment:
Shouldn't this return:
ParquetException::EofException(ss.str());
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] More informative error message on too short pages
> -------------------------------------------------------
>
> Key: PARQUET-1218
> URL: https://issues.apache.org/jira/browse/PARQUET-1218
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
