[
https://issues.apache.org/jira/browse/PARQUET-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376237#comment-16376237
]
Hans Brende commented on PARQUET-796:
-------------------------------------
Hi, I made a couple of comments related to this issue here:
https://github.com/apache/parquet-mr/pull/342#issuecomment-368341324
Any timeline on when this issue will be resolved? I'd be glad to fix it myself
if you want.
Also, [~rdblue], why not just ditch the `parquet.enable.dictionary` setting
altogether and make the condition:
{code}
if (type == OriginalType.ENUM) {
//use dictionary encoding
} else {
//don't use dictionary encoding
}
{code}
> Delta Encoding is not used when dictionary enabled
> --------------------------------------------------
>
> Key: PARQUET-796
> URL: https://issues.apache.org/jira/browse/PARQUET-796
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.9.0
> Reporter: Jakub Liska
> Priority: Critical
> Fix For: 1.9.1
>
>
> Current code doesn't enable using both Delta Encoding and Dictionary
> Encoding. If I instantiate ParquetWriter like this :
> {code}
> val writer = new ParquetWriter[Group](outFile, new GroupWriteSupport, codec,
> blockSize, pageSize, dictPageSize, enableDictionary = true, true,
> ParquetProperties.WriterVersion.PARQUET_2_0, configuration)
> {code}
> Then this piece of code :
> https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultValuesWriterFactory.java#L78-L86
> Causes that DictionaryValuesWriter is used instead of the inferred
> DeltaLongEncodingWriter.
> The original issue is here :
> https://github.com/apache/parquet-mr/pull/154#issuecomment-266489768
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
