[ 
https://issues.apache.org/jira/browse/PARQUET-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395750#comment-16395750
 ] 

ASF GitHub Bot commented on PARQUET-1209:
-----------------------------------------

xhochy closed pull request #446: PARQUET-1209: define ARROW_STATIC when 
PARQUET_ARROW_LINKAGE is static
URL: https://github.com/apache/parquet-cpp/pull/446
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bca8478c..8a8da0fc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -573,7 +573,7 @@ else()
     zstd
   )
 
-  add_definitions(-DARROW_EXPORTING)
+  add_definitions(-DARROW_STATIC)
 
   set(ARROW_LINK_LIBS
     arrow_static


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> locally defined symbol ... imported in function ..
> --------------------------------------------------
>
>                 Key: PARQUET-1209
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1209
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: rip.nsk
>            Priority: Major
>
> Got the following linker warning LNK4217:
> locally defined symbol ??1Status@arrow@@QEAA@XZ (public: __cdecl 
> arrow::Status::~Status(void)) imported in function "private: void __cdecl 
> parquet::TypedRowGroupStatistics<struct parquet::DataType<6> >::Copy(struct 
> parquet::ByteArray const &,struct parquet::ByteArray *,class 
> arrow::PoolBuffer *)" 
> (?Copy@?$TypedRowGroupStatistics@U?$DataType@$05@parquet@@@parquet@@AEAAXAEBUByteArray@2@PEAU32@PEAVPoolBuffer@arrow@@@Z)
> not sure, is it parquet or arrow issue.
> [https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4217|http://example.com/]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to