[
https://issues.apache.org/jira/browse/PARQUET-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417676#comment-16417676
]
ASF GitHub Bot commented on PARQUET-1071:
-----------------------------------------
xhochy closed pull request #449: PARQUET-1071: Check that
arrow::FileWriter::Close() is idempotent
URL: https://github.com/apache/parquet-cpp/pull/449
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/parquet/arrow/arrow-reader-writer-test.cc
b/src/parquet/arrow/arrow-reader-writer-test.cc
index 8051ff17..46218be7 100644
--- a/src/parquet/arrow/arrow-reader-writer-test.cc
+++ b/src/parquet/arrow/arrow-reader-writer-test.cc
@@ -574,6 +574,8 @@ class TestParquetIO : public ::testing::Test {
ASSERT_OK_NO_THROW(writer.NewRowGroup(values->length()));
ASSERT_OK_NO_THROW(writer.WriteColumnChunk(*values));
ASSERT_OK_NO_THROW(writer.Close());
+ // writer.Close() should be idempotent
+ ASSERT_OK_NO_THROW(writer.Close());
}
std::shared_ptr<InMemoryOutputStream> sink_;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] parquet::arrow::FileWriter::Close is not idempotent
> ---------------------------------------------------------
>
> Key: PARQUET-1071
> URL: https://issues.apache.org/jira/browse/PARQUET-1071
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Affects Versions: cpp-1.2.0
> Reporter: Wes McKinney
> Priority: Major
> Fix For: cpp-1.5.0
>
>
> Encountered a segfault when calling multiple times from Python
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
