[ 
https://issues.apache.org/jira/browse/PARQUET-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe L. Korn updated PARQUET-1279:
---------------------------------
    Component/s: parquet-cpp

> Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests
> ----------------------------------------------
>
>                 Key: PARQUET-1279
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1279
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Joshua Storck
>            Assignee: Joshua Storck
>            Priority: Minor
>              Labels: pull-request-available
>
> A number of unit tests have helper functions that use gtest/arrow ASSERT_ 
> macros. Those ASSERT_ macros simply return out of the current context and do 
> not throw exceptions or abort. Since these helper functions return void, the 
> unit test simply continues when the assertions are triggered. This can lead 
> to additional failures, such as segfaults because the test is executing code 
> that it did not expect to. By adding the gtest ASSERT_NO_FATAIL_FAILURE to 
> the calls of those helper functions in the outermost scope of the unit test, 
> the test will correctly terminate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to