[
https://issues.apache.org/jira/browse/PARQUET-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467615#comment-16467615
]
ASF GitHub Bot commented on PARQUET-1253:
-----------------------------------------
gszadovszky commented on a change in pull request #463: PARQUET-1253: Support
for new logical type representation
URL: https://github.com/apache/parquet-mr/pull/463#discussion_r186779793
##########
File path:
parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java
##########
@@ -293,6 +298,36 @@ public void testIntAnnotations() {
assertEquals(expected, reparsed);
}
+ @Test
+ public void testIntegerAnnotations() {
+ String message = "message IntMessage {" +
+ " required int32 i8 (INT(8,true));" +
+ " required int32 i16 (INT(16,true));" +
+ " required int32 i32 (INT(32,true));" +
+ " required int64 i64 (INT(64,true));" +
+ " required int32 u8 (INT(8,false));" +
+ " required int32 u16 (INT(16,false));" +
+ " required int32 u32 (INT(32,false));" +
+ " required int64 u64 (INT(64,false));" +
+ "}\n";
+
+ MessageType parsed = MessageTypeParser.parseMessageType(message);
+ MessageType expected = Types.buildMessage()
+ .required(INT32).as(LogicalTypeAnnotation.intType(8, true)).named("i8")
Review comment:
nit: I think, the static import of the method intType would help reading the
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support for new logical type representation
> -------------------------------------------
>
> Key: PARQUET-1253
> URL: https://issues.apache.org/jira/browse/PARQUET-1253
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Nandor Kollar
> Assignee: Nandor Kollar
> Priority: Major
>
> Latest parquet-format
> [introduced|https://github.com/apache/parquet-format/commit/863875e0be3237c6aa4ed71733d54c91a51deabe#diff-0f9d1b5347959e15259da7ba8f4b6252]
> a new representation for logical types. As of now this is not yet supported
> in parquet-mr, thus there's no way to use parametrized UTC normalized
> timestamp data types. When reading and writing Parquet files, besides
> 'converted_type' parquet-mr should use the new 'logicalType' field in
> SchemaElement to tell the current logical type annotation. To maintain
> backward compatibility, the semantic of converted_type shouldn't change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
