[
https://issues.apache.org/jira/browse/PARQUET-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553546#comment-16553546
]
ASF GitHub Bot commented on PARQUET-1323:
-----------------------------------------
wesm opened a new pull request #478: PARQUET-1323: Fix compiler warnings on
clang-6
URL: https://github.com/apache/parquet-cpp/pull/478
The `schema_descr_` field was unused
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Fix compiler warnings with clang-6.0
> ------------------------------------------
>
> Key: PARQUET-1323
> URL: https://issues.apache.org/jira/browse/PARQUET-1323
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: cpp-1.5.0
>
>
> Observed when building today
> {code}
> [1/23] Running thrift compiler on parquet.thrift
> [WARNING:/home/wesm/code/parquet-cpp/src/parquet/parquet.thrift:295] The
> "byte" type is a compatibility alias for "i8". Use "i8" to emphasize the
> signedness of this type.
> [15/23] Building CXX object
> CMakeFiles/parquet_objlib.dir/src/parquet/schema.cc.o
> In file included from ../src/parquet/schema.cc:18:
> ../src/parquet/schema.h:376:27: warning: private field 'schema_descr_' is not
> used [-Wunused-private-field]
> const SchemaDescriptor* schema_descr_;
> ^
> 1 warning generated.
> [20/23] Building CXX object
> CMakeFiles/parquet_objlib.dir/src/parquet/metadata.cc.o
> ../src/parquet/metadata.cc:84:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::FIXED_LEN_BYTE_ARRAY:
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/parquet/metadata.cc:82:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::BYTE_ARRAY:
> ^~~~~~~~~~~~~~~~
> ../src/parquet/metadata.cc:80:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::FLOAT:
> ^~~~~~~~~~~
> ../src/parquet/metadata.cc:78:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::DOUBLE:
> ^~~~~~~~~~~~
> ../src/parquet/metadata.cc:76:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::INT96:
> ^~~~~~~~~~~
> ../src/parquet/metadata.cc:74:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::INT64:
> ^~~~~~~~~~~
> ../src/parquet/metadata.cc:72:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::INT32:
> ^~~~~~~~~~~
> ../src/parquet/metadata.cc:70:10: warning: comparison of two values with
> different enumeration types in switch statement ('Type::type' and
> 'parquet::Type::type') [-Wenum-compare-switch]
> case Type::BOOLEAN:
> ^~~~~~~~~~~~~
> 8 warnings generated.
> [23/23] Creating library symlink debug/libparquet.so.1 debug/libparquet.so
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
