Jim, do you think that the implementation is going to make major changes to the design of how bloom filters are stored in files? I thought that concerns about what type of bloom filter to use, where to add them in the file, and what thrift object should contain the bytes were pretty much decided.
On Thu, Aug 30, 2018 at 9:17 AM Jim Apple <[email protected]> wrote: > +0, non-binding. > > Junjie and I spent a lot of time getting the C++ code to where it is now, > but all three patches (Java, -format, C++) could use some more work before > I'm fully confident we're in a good place. In particular, the code for > integrating the existing patches in with readers and writers is not even in > code review yet. > > That could lead us to discover things about the -format patch, so I'd like > to see things advance a bit before the -format patch makes it into a > release. > > I'm not -1 because I don't see any current blockers, just some risk and > unexplored territory. > -- Ryan Blue Software Engineer Netflix
