Arnaud Linz created PARQUET-1470:
------------------------------------

             Summary: Inputstream leakage in ParquetFileWriter.appendFile
                 Key: PARQUET-1470
                 URL: https://issues.apache.org/jira/browse/PARQUET-1470
             Project: Parquet
          Issue Type: Bug
          Components: parquet-mr
    Affects Versions: 1.10.0
            Reporter: Arnaud Linz


Current implementation of ParquetFileWriter.appendFile is:

 

{{public void appendFile(InputFile file) throws IOException {}}
{{    ParquetFileReader.open(file).appendTo(this);}}
{{ }}}

this method never closes the inputstream created when the file is opened in the 
ParquetFileReader constructor.

This leads for instance to TooManyFilesOpened exceptions when large merge are 
made with the parquet tools.

something  like

{{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
{{    reader.appendTo(this);}}
{{ }}}

would be cleaner.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to