I've just left code review on https://github.com/apache/arrow/pull/2555
The issues with it are not too serious, but it would have benefited from more frequently feedback throughout the 6+ month development process. There are still quite a few test failures and it doesn't build at all on Windows, so I think getting a green checkmark is higher precedence than addressing my review feedback On Mon, Jun 10, 2019 at 6:47 AM Gidon Gershinsky <[email protected]> wrote: > > As promised, a doc that describes how to get & build Parquet encryption in > C++ and Java, and how to run the samples: > https://docs.google.com/document/d/10HygpT6e9UNCn0uy9dkFkpDigNgYggccAwsS5Eqej68/edit?usp=sharing > > All questions are welcome. > > Cheers, Gidon. > > ---------- Forwarded message --------- > From: Gidon Gershinsky <[email protected]> > Date: Wed, May 22, 2019 at 7:43 PM > Subject: Re: Announcement for c++ parquet encryption > To: <[email protected]> > > > Thanks guys. We'll create a doc with a description of the current interop > tests, including details on how to build/run them.
