[
https://issues.apache.org/jira/browse/PARQUET-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881985#comment-16881985
]
ASF GitHub Bot commented on PARQUET-1609:
-----------------------------------------
jbapple commented on pull request #143: PARQUET-1609: Specify which xxhash
carefully
URL: https://github.com/apache/parquet-format/pull/143
The hash function "xxhash" is actually a number of different hash
functions including xxHash, XXH64, XXH32, and XXH3. Additionally,
these hash functions accept "seeds", as most modern hash functions do,
including MurmurHash variants.
This patch specifies that the BloomFilter hash function default is
XXH64 with a seed of 0. It omits the confusing note about the ISA and
different variants of xxHash, since XXH64 is apparently
architecture-independent.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET-1609) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support xxhash in bloom filter
> ------------------------------
>
> Key: PARQUET-1609
> URL: https://issues.apache.org/jira/browse/PARQUET-1609
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-format
> Affects Versions: format-2.6.0
> Reporter: Junjie Chen
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
