[
https://issues.apache.org/jira/browse/PARQUET-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885138#comment-16885138
]
Gabor Szadovszky commented on PARQUET-1488:
-------------------------------------------
[~rdblue],
Previously, parquet might fail in special cases for both
[dictionary|https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/filter2/dictionarylevel/DictionaryFilter.java#L393]
and
[statistics|https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/filter2/statisticslevel/StatisticsFilter.java#L369]
filters. However, because of performance reasons, column indexes invokes it
all the time. I agree, it is a regression and my previous "fix" of having it
properly documented was not enough.
[~yumwang],
I'm happy to help you with this or work on it if you don't have the time.
> UserDefinedPredicate throw NullPointerException
> -----------------------------------------------
>
> Key: PARQUET-1488
> URL: https://issues.apache.org/jira/browse/PARQUET-1488
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.11.0
> Reporter: Yuming Wang
> Assignee: Yuming Wang
> Priority: Major
>
> It throws {{NullPointerException}} after upgrade parquet to 1.11.0 when using
> {{UserDefinedPredicate}}.
> The
> [UserDefinedPredicate|https://github.com/apache/spark/blob/faf73dcd33d04365c28c2846d3a1f845785f69df/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala#L548-L578]
> is:
> {code:java}
> new UserDefinedPredicate[Binary] with Serializable {
>
> private val strToBinary = Binary.fromReusedByteArray(v.getBytes)
>
> private val size = strToBinary.length
>
>
>
> override def canDrop(statistics: Statistics[Binary]): Boolean = {
>
> val comparator =
> PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR
> val max = statistics.getMax
>
> val min = statistics.getMin
>
> comparator.compare(max.slice(0, math.min(size, max.length)), strToBinary)
> < 0 ||
> comparator.compare(min.slice(0, math.min(size, min.length)),
> strToBinary) > 0
> }
>
>
>
> override def inverseCanDrop(statistics: Statistics[Binary]): Boolean = {
>
> val comparator =
> PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR
> val max = statistics.getMax
>
> val min = statistics.getMin
>
> comparator.compare(max.slice(0, math.min(size, max.length)), strToBinary)
> == 0 &&
> comparator.compare(min.slice(0, math.min(size, min.length)),
> strToBinary) == 0
> }
>
>
>
> override def keep(value: Binary): Boolean = {
>
> UTF8String.fromBytes(value.getBytes).startsWith(
>
> UTF8String.fromBytes(strToBinary.getBytes))
>
> }
>
> }
>
> {code}
> The stack trace is:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFilters$$anon$1.keep(ParquetFilters.scala:573)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFilters$$anon$1.keep(ParquetFilters.scala:552)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter.visit(ColumnIndexFilter.java:152)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter.visit(ColumnIndexFilter.java:56)
> at
> org.apache.parquet.filter2.predicate.Operators$UserDefined.accept(Operators.java:377)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter.visit(ColumnIndexFilter.java:181)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter.visit(ColumnIndexFilter.java:56)
> at
> org.apache.parquet.filter2.predicate.Operators$And.accept(Operators.java:309)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter$1.visit(ColumnIndexFilter.java:86)
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter$1.visit(ColumnIndexFilter.java:81)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
