Thanks for working on this, Jim! I merged the current PR. On Tue, Aug 6, 2019 at 8:39 AM Jim Apple <[email protected]> wrote:
> On 2019/08/05 18:05:53, Ryan Blue <[email protected]> wrote: > > At least getting a compression union into the bloom filter header > > will help us with compatibility later if we choose to add compression > > schemes. > > That's very reasonable. I'll send a PR for that after > https://github.com/apache/parquet-format/pull/147 is checked in to avoid > rebase racing. > > At that time, I'll also send a PR to support filters with sizes that are > not a power of 2. I'll use > https://lemire.me/blog/2016/06/27/a-fast-alternative-to-the-modulo-reduction/ > to avoid the expensive modulo operation. > -- Ryan Blue Software Engineer Netflix
