[
https://issues.apache.org/jira/browse/PARQUET-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044429#comment-17044429
]
ASF GitHub Bot commented on PARQUET-1759:
-----------------------------------------
Fokko commented on pull request #743: PARQUET-1759: InternalParquetRecordReader
Use Singleton Set
URL: https://github.com/apache/parquet-mr/pull/743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> InternalParquetRecordReader Use Singleton Set
> ---------------------------------------------
>
> Key: PARQUET-1759
> URL: https://issues.apache.org/jira/browse/PARQUET-1759
> Project: Parquet
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
>
> https://github.com/apache/parquet-mr/blob/d85a8f5dcfc1381655fcccaa81a2e83ba812f6a4/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordReader.java#L260-L262
> Code currently instantiates a {{HashSet}} (with a default internal data
> structure of size 16}} and then makes it immutable. Use Collection#singleton
> to achieve this same goal with fewer lines of code and less memory
> requirements.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
