[
https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101496#comment-17101496
]
ASF GitHub Bot commented on PARQUET-1827:
-----------------------------------------
gszadovszky commented on a change in pull request #778:
URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421389575
##########
File path:
parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java
##########
@@ -766,6 +768,33 @@ public void testReuseNameInNestedStructureAtSameLevel()
throws Exception {
testParquetToAvroConversion(NEW_BEHAVIOR, schema, parquetSchema);
}
+ @Test
+ public void testUUIDType() throws Exception {
+ Schema fromAvro = Schema.createRecord("myrecord", null, null, false,
+ Arrays.asList(new Schema.Field("uuid",
LogicalTypes.uuid().addToSchema(Schema.create(STRING)), null, null)));
+ String parquet = "message myrecord {\n" +
+ " required binary uuid (STRING);\n" +
+ "}\n";
+ Schema toAvro = Schema.createRecord("myrecord", null, null, false,
+ Arrays.asList(new Schema.Field("uuid", Schema.create(STRING), null,
null)));
+
+ testAvroToParquetConversion(fromAvro, parquet);
+ testParquetToAvroConversion(toAvro, parquet);
+ }
Review comment:
To be honest I am not too familiar with parquet-avro. I've made the
changes based on the implementation/test of other logical types. Could you
explain it in more details what you would test exactly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> UUID type currently not supported by parquet-mr
> -----------------------------------------------
>
> Key: PARQUET-1827
> URL: https://issues.apache.org/jira/browse/PARQUET-1827
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Affects Versions: 1.11.0
> Reporter: Brad Smith
> Assignee: Gabor Szadovszky
> Priority: Major
> Labels: pull-request-available
>
> The parquet-format project introduced a new UUID logical type in version 2.4:
> [https://github.com/apache/parquet-format/blob/master/CHANGES.md]
> This would be a useful type to have available in some circumstances, but it
> currently isn't supported in the parquet-mr library. Hopefully this feature
> can be implemented at some point.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
