[
https://issues.apache.org/jira/browse/PARQUET-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112990#comment-17112990
]
ASF GitHub Bot commented on PARQUET-1229:
-----------------------------------------
gszadovszky commented on a change in pull request #776:
URL: https://github.com/apache/parquet-mr/pull/776#discussion_r428535767
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -442,7 +460,13 @@ static ParquetMetadata readSummaryMetadata(Configuration
configuration, Path bas
*/
@Deprecated
public static final ParquetMetadata readFooter(Configuration configuration,
Path file) throws IOException {
- return readFooter(configuration, file, NO_FILTER);
+ return readFooter(configuration, file, getDecryptionProperties(file,
configuration));
+ }
+
+ @Deprecated
+ public static final ParquetMetadata readFooter(Configuration configuration,
Path file,
Review comment:
So, all of these new methods are used inside parquet-mr? If not, then I
don't think we need them. If yes, then please, try to refactor the caller part
to use the non-deprecated ones instead. If it does not require too much effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> parquet-mr code changes for encryption support
> ----------------------------------------------
>
> Key: PARQUET-1229
> URL: https://issues.apache.org/jira/browse/PARQUET-1229
> Project: Parquet
> Issue Type: Sub-task
> Components: parquet-mr
> Reporter: Gidon Gershinsky
> Assignee: Gidon Gershinsky
> Priority: Major
> Labels: pull-request-available
>
> Addition of encryption/decryption support to the existing Parquet classes and
> APIs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
