[
https://issues.apache.org/jira/browse/PARQUET-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118703#comment-17118703
]
ASF GitHub Bot commented on PARQUET-1229:
-----------------------------------------
ggershinsky commented on a change in pull request #776:
URL: https://github.com/apache/parquet-mr/pull/776#discussion_r431856097
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -1071,12 +1229,31 @@ public BloomFilterReader
getBloomFilterDataReader(BlockMetaData block) {
*/
public BloomFilter readBloomFilter(ColumnChunkMetaData meta) throws
IOException {
long bloomFilterOffset = meta.getBloomFilterOffset();
+
+ if (0 == bloomFilterOffset) { // TODO Junjie - is there a better way to
handle this?
Review comment:
yep, this works; also, makes sense to me - we should not proceed to read
a bloom filter header, if there is no bloom filter in the file; this can be
checked via the `bloomFilterOffset` variable - it can't be 0 if a bloom filter
is present; and if no bloom filter, it can be 0 only.
I'll remove the TODO comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> parquet-mr code changes for encryption support
> ----------------------------------------------
>
> Key: PARQUET-1229
> URL: https://issues.apache.org/jira/browse/PARQUET-1229
> Project: Parquet
> Issue Type: Sub-task
> Components: parquet-mr
> Reporter: Gidon Gershinsky
> Assignee: Gidon Gershinsky
> Priority: Major
> Labels: pull-request-available
>
> Addition of encryption/decryption support to the existing Parquet classes and
> APIs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
