shangxinli commented on a change in pull request #778:
URL: https://github.com/apache/parquet-mr/pull/778#discussion_r432725762
##########
File path: parquet-avro/README.md
##########
@@ -0,0 +1,44 @@
+<!--
Review comment:
Sounds good
##########
File path:
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java
##########
@@ -421,4 +422,30 @@ private String stringifyWithScale(BigInteger i) {
}
};
}
+
+ static final PrimitiveStringifier UUID_STRINGIFIER = new
PrimitiveStringifier("UUID_STRINGIFIER") {
+ private final char[] digit = "0123456789abcdef".toCharArray();
+ @Override
+ public String stringify(Binary value) {
+ byte[] bytes = value.getBytesUnsafe();
Review comment:
Sounds good!
##########
File path:
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
##########
@@ -861,6 +871,36 @@ PrimitiveStringifier valueStringifier(PrimitiveType
primitiveType) {
}
}
+ public static class UUIDLogicalTypeAnnotation extends LogicalTypeAnnotation {
Review comment:
Sounds good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
