shangxinli commented on a change in pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#discussion_r463772543



##########
File path: 
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/example/ExampleParquetWriter.java
##########
@@ -104,15 +105,19 @@ public Builder withExtraMetaData(Map<String, String> 
extraMetaData) {
       return this;
     }
 
+    public Builder withWriteSupport(WriteSupport writeSupport) {
+      this.writeSupport = writeSupport;
+      return this;
+    }
+

Review comment:
       If we don't do that, we need to write Builder class to extend 
ParquetWriter.Builder. It should be a thin wrapper. I think we can do it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to