shangxinli commented on pull request #808: URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-670162874
Thanks Gidon! No problem. We have deployed completely, so no hurry for reviewing. As long as it is merged to upstream, we have a path to go in the future. For the Configuration setting approach, that was our initial thinking but soonly we found out it requires Parquet applications(We have all 3 query engines: Spark/Hive/Presto and in-house Parquet tools) to be changed to set the Configuration. So we change to use extended ParquetWriteSupport as plugin mode. That is how we get here today. On Thu, Aug 6, 2020 at 12:48 PM ggershinsky <notificati...@github.com> wrote: > Thanks @shangxinli <https://github.com/shangxinli> for the detailed > response, much appreciated! I want to allocate ample time to get to the > bottom of this subject, and with the weekend starting here, it might be a > problem in the next few days; but I'll get back on this early next week. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/parquet-mr/pull/808#issuecomment-670157959>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHPXKMNBBKYC4AADKCJH4WLR7MCJVANCNFSM4PMCFPJA> > . > -- Xinli Shang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org