ggershinsky commented on pull request #808: URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-671793784
Yep, a couple of concerns related to encryption. The stated goal of the crypto factory design is to be "transparent to analytic frameworks, so they can leverage Parquet modular encryption without any code changes". I think it's a good goal, and a powerful capability, worth preserving. Also, proliferation of custom channels for passing the encryption properties might lead to confusion and hard-to-trace problems in the future. Can be avoided, since the current channels can support the existing usecase requirements. Beyond encryption - I believe using a general Object as an interface parameter is considered to be problematic. Besides, adding a third channel for custom property passing can lead to issues in other areas as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
