SinghAsDev commented on pull request #222: URL: https://github.com/apache/parquet-mr/pull/222#issuecomment-699280836
> Thanks for your work and for bringing our attention to it! > > I don't have approving rights but I think this is fine. Timur will be able to check this sometime next week. > > I have one question though, I would like to understand better. Couldn't we have done a version that works for any level of nesting of lists? I wouldn't want to see a 'need to support 4 level lists' in the future. Not grounds to block this PR, we can always revisit if needed and given there will be a config flag from now on, easy to enhance later. Thanks for the review! I actually don't see a reason for having more level of nesting. The three level nesting was needed to support nulls at all levels of list definition. Moreover, this is how other models have it implemented as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
