belugabehr commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510189309
##########
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##########
@@ -127,7 +127,6 @@ public void reset() {
@Override
public void close() {
arrayOut.close();
- out.close();
Review comment:
@gszadovszky Thanks for the review!
I think this line of work should be pursued in a different ticket. This
change makes this PR's changes possible, but also puts it in line with other
implementations:
https://github.com/apache/parquet-mr/blob/dc61e510126aaa1a95a46fe39bf1529f394147e9/parquet-column/src/main/java/org/apache/parquet/column/values/plain/FixedLenByteArrayPlainValuesWriter.java#L88-L90
So if we want to change how things are closed (nice, but technically not
required) it can be addressed holistically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
