[
https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269428#comment-17269428
]
ASF GitHub Bot commented on PARQUET-1926:
-----------------------------------------
jmartone commented on a change in pull request #832:
URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562035955
##########
File path:
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName
type, LogicalTypeAnn
@Override
public ConvertedField visit(EnumType enumType, State state) {
- return visitPrimitiveType(BINARY, enumType(), state);
+ return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);
Review comment:
I find accessing these via `LogicalTypeAnnotation.enumType()` more clear
than just `enumType()`. The larger change in this PR allows any thrift type to
use a LogicalTypeAnnotation, so importing the class opens the door to further
changes that implement these logical types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add LogicalType support to ThriftType.I64Type
> ---------------------------------------------
>
> Key: PARQUET-1926
> URL: https://issues.apache.org/jira/browse/PARQUET-1926
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-thrift
> Reporter: Joshua Martone
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Adds a LogicalTypeAnnotation to the I64Type.
> This allows you to serialize timestamps and times.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
