Regarding the technical reason behind this addition - we needed it to enable encryption in one of the writing paths.
Cheers, Gidon On Thu, Jan 28, 2021 at 7:09 PM Aaron Niskode-Dossett <[email protected]> wrote: > My (non-binding) is that this is ok. In a different Apache project, we > didn't allow a change like that in minor versions and it delayed some key > work by several months. > > On Thu, Jan 28, 2021 at 3:00 AM Gabor Szadovszky <[email protected]> wrote: > > > Thanks a lot, Fokko. > > > > Regarding the breaking change. We have the maven plugin japicmp executed > in > > the verify phase so I was curious why it did not catch this issue. It > seems > > the plugin allows source incompatible changes for minor version upgrades > by > > default. It sounds reasonable to me but I am curious about the opinion of > > the community. See details about the plugin at > > https://siom79.github.io/japicmp/MavenPlugin.html. Search > > for METHOD_ADDED_TO_INTERFACE to find info about the current issue. > > > > Cheers, > > Gabor > > > > > > On Wed, Jan 27, 2021 at 11:08 PM Driesprong, Fokko <[email protected] > > > > wrote: > > > > > Thanks for running the release Gabor! > > > > > > The signature checks out: > > > MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ curl > > > https://downloads.apache.org/parquet/KEYS > KEYS > > > % Total % Received % Xferd Average Speed Time Time Time > > > Current > > > Dload Upload Total Spent Left > > > Speed > > > 100 33082 100 33082 0 0 212k 0 --:--:-- --:--:-- > --:--:-- > > > 212k > > > MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ gpg --import KEYS > > > gpg: key 97D7E8647AE7E47B: 2 signatures not checked due to missing keys > > > gpg: key 97D7E8647AE7E47B: public key "Julien Le Dem <[email protected] > >" > > > imported > > > gpg: key 7CD8278971F0F13B: 1 signature not checked due to a missing key > > > gpg: key 7CD8278971F0F13B: public key "Tianshuo Deng < > [email protected] > > >" > > > imported > > > gpg: key 4FB955854318F669: 8 signatures not checked due to missing keys > > > gpg: key 4FB955854318F669: public key "Tom White (CODE SIGNING KEY) < > > > [email protected]>" imported > > > gpg: key FCB3CBD9D3924CCD: public key "Ryan Blue (CODE SIGNING KEY) < > > > [email protected]>" imported > > > gpg: key A9358ED82F7D7992: public key "Alex Levenson < > > > [email protected]>" imported > > > gpg: key 442C7FAC7C58F0FE: public key "Alex Levenson < > > [email protected] > > > >" > > > imported > > > gpg: key 29D94E228CAAD602: 2 signatures not checked due to missing keys > > > gpg: key 29D94E228CAAD602: public key "Uwe L. Korn <[email protected]>" > > > imported > > > gpg: key 021057DBF048F543: public key "Gabor Szadovszky < > > [email protected] > > > >" > > > imported > > > gpg: Total number processed: 8 > > > gpg: imported: 8 > > > gpg: marginals needed: 3 completes needed: 1 trust model: pgp > > > gpg: depth: 0 valid: 1 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 1u > > > gpg: next trustdb check due at 2021-04-08 > > > MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ gpg --verify > > > apache-parquet-1.12.0.tar.gz.asc apache-parquet-1.12.0.tar.gz > > > gpg: Signature made wo 27 jan 16:36:01 2021 CET > > > gpg: using RSA key > > 6FB82970311551C7CEF131F5021057DBF048F543 > > > gpg: Good signature from "Gabor Szadovszky <[email protected]>" > [unknown] > > > gpg: WARNING: This key is not certified with a trusted signature! > > > gpg: There is no indication that the signature belongs to the > > > owner. > > > Primary key fingerprint: 6FB8 2970 3115 51C7 CEF1 31F5 0210 57DB F048 > > F543 > > > > > > Also, the hash is looking good: > > > MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ shasum -a 512 > > > apache-parquet-1.12.0.tar.gz > > > > > > > > > f19e13e3997027f66f82a8cbacff8e832545250a1d84292234d3da45effdcf41a42288dad37ee8f4d04e29415bc58e2f170abdacd9c3ffe6bff4f68d117c32ec > > > apache-parquet-1.12.0.tar.gz > > > MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ cat > > > apache-parquet-1.12.0.tar.gz.sha512 > > > > > > > > > f19e13e3997027f66f82a8cbacff8e832545250a1d84292234d3da45effdcf41a42288dad37ee8f4d04e29415bc58e2f170abdacd9c3ffe6bff4f68d117c32ec > > > apache-parquet-1.12.0.tar.gz > > > > > > I've checked against Iceberg, and the API is broken for the OutputFile: > > > > > > MacBook-Pro-van-Fokko:incubator-iceberg fokkodriesprong$ git diff > > > > > > *diff --git > > > a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java > > > b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java* > > > > > > *index d65b8d63..8ce32a7b 100644* > > > > > > *--- a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java* > > > > > > *+++ b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java* > > > > > > @@ -162,6 +162,11 @@ class ParquetIO { > > > > > > public long defaultBlockSize() { > > > > > > return 0; > > > > > > } > > > > > > + > > > > > > + @Override > > > > > > + public String getPath() { > > > > > > + return this.file.location(); > > > > > > + } > > > > > > } > > > > > > This change is introduced here: > > > > > > > > > https://github.com/apache/parquet-mr/commit/5c6916c23cb2b9c225ea80328550ee0e11aee225 > > > > > > It is breaking, but not sure if it is blocking. > > > > > > A +1 (non-binding) from my side! > > > > > > Cheers, Fokko > > > > > > > > > > > > > > > Op wo 27 jan. 2021 om 16:46 schreef Gabor Szadovszky <[email protected] > >: > > > > > > > Hi everyone, > > > > > > > > I propose the following RC to be released as the official Apache > > Parquet > > > > 1.12.0 release. > > > > > > > > The commit id is ad59c33e53276572c105b4ccac71293e988adc30 > > > > * This corresponds to the tag: apache-parquet-1.12.0-rc1 > > > > * > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/tree/ad59c33e53276572c105b4ccac71293e988adc30 > > > > > > > > The release tarball, signature, and checksums are here: > > > > * > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.12.0-rc1 > > > > > > > > You can find the KEYS file here: > > > > * https://downloads.apache.org/parquet/KEYS > > > > > > > > Binary artifacts are staged in Nexus here: > > > > * > > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > > > > > > > This release includes the features Parquet Modular Encryption and > > Parquet > > > > Bloom Filter. See details at: > > > > * > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/blob/apache-parquet-1.12.0-rc1/CHANGES.md > > > > > > > > Please download, verify, and test. > > > > > > > > Please vote in the next 72 hours. > > > > > > > > [ ] +1 Release this as Apache Parquet 1.12.0 > > > > [ ] +0 > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > PS.: Starting with RC1 instead of RC0 because I've missed to update > the > > > > CHANGES.md at the first time. > > > > > > > > > > > > -- > Aaron Niskode-Dossett, Data Engineering -- Etsy >
