pitrou commented on a change in pull request #166:
URL: https://github.com/apache/parquet-format/pull/166#discussion_r603972065



##########
File path: README.md
##########
@@ -17,7 +17,7 @@
   - under the License.
   -->
 
-# Parquet [![Build 
Status](https://travis-ci.org/apache/parquet-format.png?branch=master)](http://travis-ci.org/apache/parquet-format)
+# Parquet [![Build 
Status](https://github.com/apache/parquet-format/workflows/Test/badge.svg)](https://github.com/apache/parquet-format/actions)

Review comment:
       I believe the URL should be 
https://github.com/apache/parquet-format/actions/workflows/test.yml/badge.svg
   
   (see https://github.com/apache/arrow/actions/workflows/cpp.yml/badge.svg for 
an example on another repo)

##########
File path: .github/workflows/test.yml
##########
@@ -0,0 +1,36 @@
+name: Test
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ '1.8', '11' ]
+    name: Build Parquet with JDK ${{ matrix.java }} and ${{ matrix.codes }}

Review comment:
       `matrix.codes` doesn't seem to point to anything. Just drop it?
   (see formatted labels in 
https://github.com/gszadovszky/parquet-format/runs/1816450871 )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to