[
https://issues.apache.org/jira/browse/PARQUET-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312431#comment-17312431
]
ASF GitHub Bot commented on PARQUET-2012:
-----------------------------------------
dossett commented on a change in pull request #886:
URL: https://github.com/apache/parquet-mr/pull/886#discussion_r604952270
##########
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoParquetWriter.java
##########
@@ -77,26 +81,24 @@ public ProtoParquetWriter(Path file, Class<? extends
Message> protoMessage,
* @param file The file name to write to.
* @param protoMessage Protobuf message class
* @throws IOException if there is an error while writing
+ *
+ * @deprecated will be removed in 2.0.0.; Used ProtoParquetWriter.Builder
instead
*/
public ProtoParquetWriter(Path file, Class<? extends Message> protoMessage)
throws IOException {
this(file, protoMessage, CompressionCodecName.UNCOMPRESSED,
DEFAULT_BLOCK_SIZE, DEFAULT_PAGE_SIZE);
}
-
public static <T> Builder<T> builder(Path file) {
return new Builder<T>(file);
}
public static <T> Builder<T> builder(OutputFile file) {
return new Builder<T>(file);
}
-
private static <T extends MessageOrBuilder> WriteSupport<T>
writeSupport(Class<? extends Message> protoMessage) {
- return new ProtoWriteSupport<T>(protoMessage);
+ return new ProtoWriteSupport<>(protoMessage);
Review comment:
Teeny tiny clean-up to remove a redundant type parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ProtoParquetWriter constructors should be updated
> -------------------------------------------------
>
> Key: PARQUET-2012
> URL: https://issues.apache.org/jira/browse/PARQUET-2012
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-protobuf
> Affects Versions: 1.12.0
> Reporter: Aaron Blake Niskode-Dossett
> Assignee: Aaron Blake Niskode-Dossett
> Priority: Minor
>
> The constructors should be marked as deprecated and internal uses of them
> switched to the Builder pattern
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
