[
https://issues.apache.org/jira/browse/PARQUET-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313030#comment-17313030
]
ASF GitHub Bot commented on PARQUET-2012:
-----------------------------------------
gszadovszky commented on a change in pull request #886:
URL: https://github.com/apache/parquet-mr/pull/886#discussion_r605496828
##########
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoParquetWriter.java
##########
@@ -43,6 +43,8 @@
* @param blockSize HDFS block size
* @param pageSize See parquet write up. Blocks are subdivided
into pages for alignment and other purposes.
* @throws IOException if there is an error while writing
+ *
+ * @deprecated will be removed in 2.0.0.; Used ProtoParquetWriter.Builder
instead
Review comment:
Please, also use the java annotation `@Deprecated` for all the
deprecated methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ProtoParquetWriter constructors should be updated
> -------------------------------------------------
>
> Key: PARQUET-2012
> URL: https://issues.apache.org/jira/browse/PARQUET-2012
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-protobuf
> Affects Versions: 1.12.0
> Reporter: Aaron Blake Niskode-Dossett
> Assignee: Aaron Blake Niskode-Dossett
> Priority: Minor
>
> The constructors should be marked as deprecated and internal uses of them
> switched to the Builder pattern
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
