dossett commented on a change in pull request #813:
URL: https://github.com/apache/parquet-mr/pull/813#discussion_r605629575
##########
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoParquetReader.java
##########
@@ -33,8 +33,14 @@
public class ProtoParquetReader<T extends MessageOrBuilder> extends
ParquetReader<T> {
@SuppressWarnings("unchecked")
- public static <T> Builder<T> builder(Path file) {
- return ParquetReader.builder(new ProtoReadSupport(), file);
+ public static <T extends MessageOrBuilder> Builder<T> builder(Path file) {
+ return (Builder<T>) ParquetReader.builder(new ProtoReadSupport<>(), file);
+ }
+
+ @SuppressWarnings("unchecked")
+ public static <T extends MessageOrBuilder> Builder<T> builder(Path file, T
message) {
Review comment:
`message` is unused in this method, should it be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
