[
https://issues.apache.org/jira/browse/PARQUET-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317750#comment-17317750
]
ASF GitHub Bot commented on PARQUET-2005:
-----------------------------------------
gszadovszky commented on a change in pull request #175:
URL: https://github.com/apache/parquet-format/pull/175#discussion_r610419366
##########
File path: src/main/java/org/apache/parquet/format/InterningProtocol.java
##########
@@ -224,6 +224,11 @@ public ByteBuffer readBinary() throws TException {
return delegate.readBinary();
}
+ @Override
+ public int getMinSerializedSize(byte b) throws TException {
+ return 0;
Review comment:
I think, we should return `delegate.getMinSerializedSize(b)` instead of
`0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade thrift to 0.14.1
> ------------------------
>
> Key: PARQUET-2005
> URL: https://issues.apache.org/jira/browse/PARQUET-2005
> Project: Parquet
> Issue Type: Improvement
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
> Fix For: 1.13.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
