[ 
https://issues.apache.org/jira/browse/PARQUET-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338958#comment-17338958
 ] 

ASF GitHub Bot commented on PARQUET-2037:
-----------------------------------------

gszadovszky opened a new pull request #901:
URL: https://github.com/apache/parquet-mr/pull/901


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet 
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references 
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Write INT96 with parquet-avro
> -----------------------------
>
>                 Key: PARQUET-2037
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2037
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-avro, parquet-mr
>            Reporter: Gabor Szadovszky
>            Assignee: Gabor Szadovszky
>            Priority: Major
>
> This jira is about the write path of PARQUET-1928. 
> The issue here is how to identify an Avro FIXED type that was an INT96 
> before. Of course, this feature would be behind a configuration flag 
> similarly to PARQUET-1928. But even with this flag it is not obvious to 
> differentiate a "simple" FIXED[12] byte from one that was an INT96 before.
> Two options to solve this issue:
> * Write the doc field of the avro schema that the FIXED value was an INT96.
> * Instead of implementing a configuration flag let the user specify the names 
> of the columns to be converted to INT96 via the configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to