shangxinli commented on pull request #928: URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931386393
@gszadovszky The first two commits had the OffsetIndex issue. The 3rd commit added test verifyOffsetIndexes() which verified not only the offset but also the page(header and payload) read with that offset index. That tests can reproduce the issue and solved the issue in the 3rd commit. The last commit is not solving any issue but just to take an alternative way(we think it is less error-prone). So no tests were added because the tests added earlier already covered that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
