ggershinsky commented on pull request #928: URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933506341
> So I just simply revert my change that partially renamed AAD to pageHeaderAAD. I looked at the util.java file and I see there are a lot of other places all using AAD instead of a more specific AAD. We can have another PR to fix them all. I think this is fine. My earlier comment was addressed to code where it was not clear what kind of AADs are calculated/used. This is already fixed, thanks. As for the Util.java - it is very clear about the module kinds, with functions like writePageHeader etr. So its ok to leave the parameter name as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
