martin-g commented on pull request #924: URL: https://github.com/apache/parquet-mr/pull/924#issuecomment-968646400
I think it is safe to merge this PR! Recent builds have such logs: 1. ``` Still running (3 of 60): mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Dorg.slf4j.simpleLogger.logFile=mvn-install.log ``` i.e. `mvn install` passes in 2-3 minutes. It is less than 10 mins, so it is OK to drop `travis_wait`! 2. ``` Still running (22 of 60): mvn verify --batch-mode javadoc:javadoc -P ci-test,default -Dorg.slf4j.simpleLogger.logFile=mvn-verify.log WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release Thrift version 0.15.0 SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. Thrift version 0.15.0 message msg { required group binary_col (LIST) { repeated group list { required binary element; } } required group int32_col (LIST) { repeated group list { required int32 element; } } } ``` i.e. `mvn verify` took 22 mins to run but it has many WARN logs which "keep alive" the console. For example: https://app.travis-ci.com/github/apache/parquet-mr/jobs/546236418 If the build stucks for any reason then Travis will kill it after 10 mins of silence, instead of waiting for the `60` mins defined with `travis_wait`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
