shangxinli commented on a change in pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#discussion_r820904662



##########
File path: 
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetReader.java
##########
@@ -46,10 +47,19 @@
 
   private static final Path FILE_V1 = createTempFile();
   private static final Path FILE_V2 = createTempFile();
-  private static final List<PhoneBookWriter.User> DATA = 
Collections.unmodifiableList(makeUsers(10000));
+  private static final Path STATIC_FILE_WITHOUT_COL_INDEXES = 
createPathFromCP("/test-file-with-no-column-indexes-1.parquet");

Review comment:
       I am not sure if it is a good idea to check in a data file. Can you 
check if it is possible to stop generating offset index in the current version 
of Parquet? 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to