emkornfield commented on a change in pull request #900:
URL: https://github.com/apache/parquet-mr/pull/900#discussion_r836042758
##########
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java
##########
@@ -35,22 +35,49 @@
import java.util.List;
+import static org.apache.parquet.schema.LogicalTypeAnnotation.TimeUnit;
+import static org.apache.parquet.schema.LogicalTypeAnnotation.dateType;
import static org.apache.parquet.schema.LogicalTypeAnnotation.enumType;
import static org.apache.parquet.schema.LogicalTypeAnnotation.listType;
import static org.apache.parquet.schema.LogicalTypeAnnotation.mapType;
import static org.apache.parquet.schema.LogicalTypeAnnotation.stringType;
-import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.*;
+import static org.apache.parquet.schema.LogicalTypeAnnotation.timeType;
+import static org.apache.parquet.schema.LogicalTypeAnnotation.timestampType;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY;
+import static
org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BOOLEAN;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.DOUBLE;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.FLOAT;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT32;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT64;
/**
* Converts a Protocol Buffer Descriptor into a Parquet schema.
*/
public class ProtoSchemaConverter {
+ public static final String PROTOBUF_TIMESTAMP_TYPE =
"google.protobuf.Timestamp";
+ public static final String PROTOBUF_DATE_TYPE = "google.type.Date";
+ public static final String PROTOBUF_TIME_TYPE = "google.type.TimeOfDay";
+ public static final String PROTOBUF_DOUBLE_TYPE =
"google.protobuf.DoubleValue";
+ public static final String PROTOBUF_FLOAT_TYPE =
"google.protobuf.FloatValue";
+ public static final String PROTOBUF_INT64_TYPE =
"google.protobuf.Int64Value";
+ public static final String PROTOBUF_UINT64_TYPE =
"google.protobuf.UInt64Value";
+ public static final String PROTOBUF_INT32_TYPE =
"google.protobuf.Int32Value";
+ public static final String PROTOBUF_UINT32_TYPE =
"google.protobuf.UInt32Value";
+ public static final String PROTOBUF_BOOL_TYPE = "google.protobuf.BoolValue";
+ public static final String PROTOBUF_STRING_TYPE =
"google.protobuf.StringValue";
+ public static final String PROTOBUF_BYTES_TYPE =
"google.protobuf.BytesValue";
+
private static final Logger LOG =
LoggerFactory.getLogger(ProtoSchemaConverter.class);
private final boolean parquetSpecsCompliant;
+ private final boolean unwrapProtoWrappers;
public ProtoSchemaConverter() {
- this(false);
+ this(false, false);
+ }
+
+ public ProtoSchemaConverter(boolean parquetSpecsCompliant) {
Review comment:
please add docs for all new publicly facingin parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
