rdblue commented on code in PR #960:
URL: https://github.com/apache/parquet-mr/pull/960#discussion_r860144940
##########
parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java:
##########
@@ -49,6 +59,19 @@ public static ByteBufferInputStream wrap(List<ByteBuffer>
buffers) {
}
}
+ public static ByteBufferInputStream wrap(ByteBuffer buffer, int offset, int
count) {
Review Comment:
What is the purpose of these methods? We already wrap buffers, why not have
the caller handle this?
It's also really strange to pass a buffer with an offset and a "count" (do
you mean length?) because buffers already have that information built in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
