[
https://issues.apache.org/jira/browse/PARQUET-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529469#comment-17529469
]
ASF GitHub Bot commented on PARQUET-1020:
-----------------------------------------
guillaume-fetter opened a new pull request, #963:
URL: https://github.com/apache/parquet-mr/pull/963
### Jira
- [X] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title:
- https://issues.apache.org/jira/browse/PARQUET-1020
### Tests
- [X] My PR adds the following unit test:
- testProto3SimplestDynamicMessage in
parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoWriteSupportTest.java
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
This is sort of a resubmission of
https://github.com/apache/parquet-mr/pull/414 as the PR has been left open for
quite some time, and the branch has diverged a bit.
Please tell me if this is okay.
> Add support for Dynamic Messages in parquet-protobuf
> ----------------------------------------------------
>
> Key: PARQUET-1020
> URL: https://issues.apache.org/jira/browse/PARQUET-1020
> Project: Parquet
> Issue Type: New Feature
> Reporter: Alex Buck
> Assignee: Alex Buck
> Priority: Major
>
> Hello. We would like to pass in a DynamicMessage rather than using the
> generated protobuf classes to allow us to make our job very generic.
> I think this could be achieved by setting the descriptor upfront, similarly
> to how there is a ProtoParquetOutputFormat today.
> In ProtoWriteSupport in the init method it could then generate the parquet
> schema created by ProtoSchemaConverter using the passed in descriptor, rather
> than taking it from the generated proto class.
> Would there be interest in incorporating this change? If so does the approach
> above sound sensible? I am happy to do a pull request
> initial PR here: https://github.com/apache/parquet-mr/pull/414
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
