ggershinsky commented on PR #975: URL: https://github.com/apache/parquet-mr/pull/975#issuecomment-1157577513
> The test takes about 2300 milli seconds on my laptop. Ok, this is reasonable. If this time is sufficient for reliably testing the upper limit of FPPs, it should be good enough to also check the lower limit, eg `exist > totalCount * (testFpp[i] * 0.9)` , or `exist > totalCount * (testFpp[i] * 0.5)` , or even `exist > 0`. What do you think? This way, we'll be certain the test passes not because `exist` is just 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
