mwong38 commented on code in PR #900:
URL: https://github.com/apache/parquet-mr/pull/900#discussion_r912545610
##########
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java:
##########
@@ -97,6 +127,46 @@ public MessageType convert(Class<? extends Message>
protobufClass) {
private <T> Builder<? extends Builder<?, GroupBuilder<T>>, GroupBuilder<T>>
addField(FieldDescriptor descriptor, final GroupBuilder<T> builder) {
if (descriptor.getJavaType() == JavaType.MESSAGE) {
+ if (unwrapProtoWrappers) {
+ String typeName = descriptor.getMessageType().getFullName();
+ if (typeName.equals(PROTOBUF_TIMESTAMP_TYPE)) {
+ return builder.primitive(INT64,
getRepetition(descriptor)).as(timestampType(true, TimeUnit.NANOS));
Review Comment:
I don't think it's worth complicating the API. The Timestamp common Proto
stores time in nanoseconds. There's no good reason to deviate from that or to
truncate the resolution. If the user wishes to do more manipulation, it can be
done downstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
