[
https://issues.apache.org/jira/browse/PARQUET-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565884#comment-17565884
]
ASF GitHub Bot commented on PARQUET-2165:
-----------------------------------------
steveloughran opened a new pull request, #979:
URL: https://github.com/apache/parquet-mr/pull/979
Remove the deprecated classes PathGlobPattern and
DeprecatedFieldProjectionFilter so that Parquet will
compile against hadoop 3.x.
If a thrift reader is configured to use the now-deleted filter,
by setting the filter in "parquet.thrift.column.filter",
a ThriftProjectionException will be thrown.
### Jira
- [X] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
It modifies the test `TestParquetToThriftReadWriteAndProjection` to switch
to the strict filter in all test cases where the old one was being used.
*these tests now all fail with `ThriftProjectionException: No columns have
been selected`
I could cut the tests "obsolete" but it would seem to me that moving the
tests to the strict filter would be better. I will just need help doing this.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> remove deprecated PathGlobPattern and DeprecatedFieldProjectionFilter to
> compile on hadoop 3.2+
> -----------------------------------------------------------------------------------------------
>
> Key: PARQUET-2165
> URL: https://issues.apache.org/jira/browse/PARQUET-2165
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-thrift
> Affects Versions: 1.12.3
> Reporter: Steve Loughran
> Priority: Major
>
> remove the deprecated PathGlobPattern class and its uses from parquet-thrift
> The return types from the hadoop GlobPattern code changed in HADOOP-12436;
> in the class as is will not compile against hadoop 3.x
> Parquet releases compiled against hadoop 2.x will not be able to instantiate
> these classes on a hadoop 3 release, because things will not link.
> Nobody appears to have complained about the linkage problem to the extent of
> filing a JIRA.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
