jnturton commented on PR #959:
URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1191048626

   > Are you concerned about leaking if release/close isn't called? I'm pretty 
sure that would result in leaks. I suppose that might be solvable if we added a 
finalize() method that called release(). That might solve the problem. Should 
we do that?
   
   My 2c: finalize() is problematic and deprecated in Java so I don't recommend 
adding it. The requirement here that the caller must close after they're 
finished is totally reasonable and to be found in APIs everywhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to