[
https://issues.apache.org/jira/browse/PARQUET-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583039#comment-17583039
]
ASF GitHub Bot commented on PARQUET-2173:
-----------------------------------------
steveloughran commented on code in PR #985:
URL: https://github.com/apache/parquet-mr/pull/985#discussion_r951589888
##########
pom.xml:
##########
@@ -160,7 +160,11 @@
<exclusions>
<exclusion>
<groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
+ <artifactId>*</artifactId>
Review Comment:
it means that
1. classic log4j is excluded
2. slf4j-reload4j is excluded
3. when the hadoop move to log4j2 is finally shipped, its slf4j bindings
will be excluded too.
exclusions 1 and 2 could be done explicitly, but #3 is unclear until
something ships. (hadoop trunk/3.4 is on log4j2, but the move isn't complete)
> Fix parquet build against hadoop 3.3.3+
> ---------------------------------------
>
> Key: PARQUET-2173
> URL: https://issues.apache.org/jira/browse/PARQUET-2173
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cli
> Affects Versions: 1.13.0
> Reporter: Steve Loughran
> Priority: Major
>
> parquet won't build against hadoop 3.3.3+ because it swapped out log4j 1.17
> for reload4j, and this creates maven dependency problems in parquet cli
> {code}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze-only (default) @ parquet-cli
> ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] ch.qos.reload4j:reload4j:jar:1.2.22:provided
> {code}
> the hadoop common dependencies need to exclude this jar and any changed slf4j
> ones.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
