[ 
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597667#comment-17597667
 ] 

ASF GitHub Bot commented on PARQUET-758:
----------------------------------------

gszadovszky commented on PR #184:
URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1231323733

   > > It would not be too easy to implement the half-precision floating point 
comparison logic since java does not have such a primitive type.
   > 
   > While not effortless, it should be relatively easy to adapt one of the 
routines that's available from other open source projects, such as Numpy: 
https://github.com/numpy/numpy/blob/8a0859835d3e6002858b9ffd9a232b059cf9ea6c/numpy/core/src/npymath/halffloat.c#L169-L190
 (`npy_half` is just an unsigned 16-bit integer in this context)
   
   It is not that trivial. For the half-precision floating point numbers we do 
not have native support for either cpp or java so we can define the total 
ordering as we want. But we shall do the same for the existing floating point 
numbers that most languages have native support. Even though they are following 
the same standard the total ordering either does not exist or have different 
implementations. See 
[PARQUET-1222(https://issues.apache.org/jira/browse/PARQUET-1222) for details.




> [Format] HALF precision FLOAT Logical type
> ------------------------------------------
>
>                 Key: PARQUET-758
>                 URL: https://issues.apache.org/jira/browse/PARQUET-758
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-format
>            Reporter: Julien Le Dem
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to