jianchun opened a new pull request, #1022: URL: https://github.com/apache/parquet-mr/pull/1022
When used memSize is 0, ColumnWriterV1 runs into floating point div by 0 issue, resulting in valueCountForNextSizeCheck become about 1G. (floating point div by 0 is Infinity, casting to int becomes MAX_INT.) Then it will keep buffering data and won't emit a page until 1G rows or close(). This potential too much buffering can easily overflow underlying CapacityByteArrayOutputStream, which uses int type as size count and does not check for overflow. When CapacityByteArrayOutputStream size overflows int it becomes negative. Parquet write path does not check negative size and writes asis into V1PageHeader uncompressed_page_size. This corrupts parquet file, as parquet reader allocates uncompressed_page_size read buffer, and throws NegativeArraySizeException when it's negative. Fixed by applying an upper bound to valueCountForNextSizeCheck, also added overflow check. This bug exists in 1.10.x and before. ColumnWriteStoreV2 has a small parenthesis misplacement bug, resulting in unintended casting to float then back to long before division. So it is an integer division instead of intended floating point division. It doesn't cause problem because it applies other min/max constraints. Fixed as well. (This issue also exists in 1.11.x) Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-XXX - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
